Closed anuragxxd closed 1 year ago
vercel[bot]
commented
1 year ago The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| landing-page | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Sep 21, 2023 6:22am |
anuragxxd
commented
1 year ago This sounds good. Please try to resolve the CI issue.
Yeah actually OC deployment failed due to some token issue! I am not sure what it is (as I have not set it up initially) but will look into it.
anuragxxd
commented
1 year ago Hey @uniqueg, the env variable here have expired & is giving the error 403 now here https://github.com/elixir-cloud-aai/landing-page/blob/dev/.github/workflows/build.yml#L53. Also I am not sure why are we deploying the app on the PR itself. Isn't the deployment will be limited to the dev & master.
Maybe @Socuz will have more idea regarding this as he have set this up initially.
trispera
commented
1 year ago Hello, This line https://github.com/elixir-cloud-aai/landing-page/blob/dev/.github/workflows/build.yml#L51 gave the error. I don't why, maybe an issue with Docker Hub? Since I re-ran the jobs and it passed. Regarding the deployment of the application, it runs GitHub Actions when a PR is opened on dev branch.
anuragxxd
commented
1 year ago Thanks for the prompt help @Socuz, I think the deployment will only be limited when the pr is merged in the dev as anyone publicly have the access to make the pr but not all have the access to push to dev (I will change it to the push rather than pull_request). For the pr deployment we are using vercel & it work completely fine.
Also can you please help me find the deployment URL?
trispera
commented
1 year ago Ok, it can be improved with this: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#running-your-pull_request-workflow-when-a-pull-request-merges
I am not sure what you mean by deployment URL. Where the app is hosted?
anuragxxd
commented
1 year ago Ok, it can be improved with this: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#running-your-pull_request-workflow-when-a-pull-request-merges
I am not sure what you mean by deployment URL. Where the app is hosted?
Yes!
Description
Fixes #52
This pull request addresses several important aspects:
Google Analytics Support: The primary objective is to integrate Google Analytics support into our landing page. This will enable us to gather valuable insights into user behavior and engagement.
Simplifying Consent Management: It also resolves the issue highlighted in this discussion by streamlining the consent management process. Instead of relying on two additional libraries, we are now reducing unnecessary bloat in our codebase.
Enhanced Consent Control: To manage user consents efficiently, we are leveraging Google's Official consent support. With this implementation, the Google Analytics tag will load on the initial page render, but tracking will not commence until the user explicitly clicks the "Accept" button. Additionally, if a user declines tracking, this decision will be conveyed to the Google Analytics dashboard, ensuring transparency and compliance with privacy regulations.
These improvements aim to enhance the user experience, streamline our codebase, and provide more precise control over data collection and user consents.