elixir-cloud-aai / proTES

Proxy service for injecting middleware into GA4GH TES requests
Apache License 2.0
6 stars 6 forks source link

Enforce immutability for incoming task document #142

Open Ayush5120 opened 1 year ago

Ayush5120 commented 1 year ago

The incoming task document serves as a log/reference to what the user sent, which is needed for accounting/audit purposes. Therefore, only the parts that are provided by the client should be immutable, and the outgoing request can be modified according to middleware configuration.

uniqueg commented 1 year ago

Isn't this already accounted for by #141, @Ayush5120? If so, you can close this issue.

Ayush5120 commented 1 year ago

No, as discussed this was supposed to be done once the naming issue was fixed and now I can see the naming of the TES task was fixed in #141 , will fix this soon in the upcoming Prs.

uniqueg commented 1 year ago

So you really wanna make it immutable. Nice. I like that :)