elixir-cloud-aai / proTES

Proxy service for injecting middleware into GA4GH TES requests
Apache License 2.0
5 stars 6 forks source link

fix: premature system error state #143

Closed SohamRatnaparkhi closed 1 year ago

SohamRatnaparkhi commented 1 year ago

IMPORTANT: Please create an issue before filing a pull request! Changes need to be discussed before proceeding. Please read the contribution guidelines.

Details

Resolves #139

When submission of the task to the best TES instance fails the state is set to SYSTEM_ERROR.Ideally, it should not set the state to SYSTEM_ERROR until the task submission fails on all the available TES instances.

To solve this, I moved the code-block which was specifically related to setting the error state to SYSTEM ERROR to the place which will only be touched if all the TES instances fail. But for every failed instance, a message will be logged.

Testing

NA

Documentation

NA

Style

My code adheres to coding convention of this project.

Closing issues

closes issue: #139