Closed SohamRatnaparkhi closed 1 year ago
Thanks @SohamRatnaparkhi :)
The TES specification does not say anything about case sensitivity, which is a pity. However, without any other information, I would interpret that to mean that the filtering should be case sensitive.
Request a review when you are ready.
Thanks @SohamRatnaparkhi :)
The TES specification does not say anything about case sensitivity, which is a pity. However, without any other information, I would interpret that to mean that the filtering should be case sensitive.
Request a review when you are ready.
Okay cool! Then I am requesting a review with case sensitive regex.
In future if we need to make it case insensitive, then we just need to add
/i
or a{ option : 'i' }
to regex/filter_dict
Thanks, @SohamRatnaparkhi I have tested it and it works fine.
IMPORTANT: Please create an issue before filing a pull request! Changes need to be discussed before proceeding. Please read the contribution guidelines.
Details
Solves issue #127
Currently, when name_prefix is passed as a parameter with
\task
route, the tasks aren't filtered. This PR involves adding a wildcard regular expression matching and filtering of tasks with respect to name_prefix (if present). Note : Filtering is strongly case sensitive. Therefore, if name_prefix="Foo" then tasks with their names starting with "Foo such as Foo1, Foo2 (Foo*) will be considered but (foo, FOo, etc.) wont be considered.Testing NA
Documentation NA
Style
Code adheres to styling of the project.
Closing issues
Closes #127
Credit
Add your credentials to the list of contributors once your pull request was merged.