search

elixir-cloud-aai / proTES

Proxy service for injecting middleware into GA4GH TES requests
Apache License 2.0
5 stars 6 forks source link

Allow users to configure security definitions #50

Closed robertopreste closed 4 years ago

robertopreste commented 4 years ago

Is your feature request related to a problem? Please describe. If I want to build proTES without providing (or providing at a later time) an OpenAPI file, I won't be able to do it because it is currently required in app.py, since add_security_definitions=True.

Describe the solution you'd like A very easy solution to this would be to get that flag from the app_config.yaml file, where the authorization_required key is already available, thus changing the above-mentioned line in app.py to add_security_definitions=get_conf(config, 'security', 'authorization_required'). This is consistent with what is done for other arguments of register_openapi.

Describe alternatives you've considered At the moment I'm solving this by simply replacing the original app.py file with my own version that has that simple code change already in place, but it is quite annoying.

Additional context N/A

uniqueg commented 4 years ago

Thanks for the suggestion and detailed feature request. It's a good idea!

We are working hard for preparing for a COVID-19 virtual hackathon that's gonna take place in the second week of April (perhaps you are interested?). Not sure if I will be able to do it before after that is concluded. Possibly someone else will, but no guarantees. If you'd rather have it sooner, you are very welcome to file a PR and assign me as reviewer. I'll surely merge this.

robertopreste commented 4 years ago

Sure, I'm happy to open a PR for that, it's an easy fix. Thanks for your availability, and for sharing the hackathon, will surely have a look at that!