search

elixir-cloud-aai / proTES

Proxy service for injecting middleware into GA4GH TES requests
Apache License 2.0
5 stars 6 forks source link

Minor fix #77

Closed Ayush5120 closed 1 year ago

Ayush5120 commented 1 year ago
  1. Added exceptions for tasks not found in GET /tasks/{id} endpoint.
  2. Removed unnecessary config files.
uniqueg commented 1 year ago

Removing config handler is now addressed here: https://github.com/elixir-cloud-aai/proTES/pull/100

Ayush5120 commented 1 year ago

Additional errors look like a good thing, but it seems to me that (1) EngineProblem should also show up in the exceptions dictionary and (2) these errors should actually be used somewhere in the code?

Re: removal of config parser, see other message (basically, this is already taken care of in another PR)

Ok I will add EngineProblem as stated and (2) Yeah I do found that most of the errors are defined and never used I will fix them in next commit.

uniqueg commented 1 year ago

I'm not sure if this PR is still needed after refactoring proTES in November. Can you please check @Ayush5120, and either update or close the PR? :pray:

Ayush5120 commented 1 year ago

Yes @uniqueg you are right, this was handled in the pr #114. Hence closing this PR.