search

elixir-cloud-aai / tesk-api

GA4GH TES API Service that translates tasks into Kubernetes Batch API calls
Apache License 2.0
7 stars 18 forks source link

Upgrade io.kubernetes to 11.0.1 #27

Closed lvarin closed 2 years ago

lvarin commented 3 years ago

These are the minimum changes to make it work with v11.0.1, the minimum non-vulnerable version.

lvarin commented 3 years ago

We need someone to review this

aniewielska commented 3 years ago

Looks alright at first glance. I can see that you changed interpretation of GB from decimal to binary, which probably makes sense and to be fair it should be clarified in the TES spec itself as it is now ambiguous. If patching is now properly handled by the client (it was not previously), a cleanup of a workaround would do. Have a look here: https://github.com/elixir-cloud-aai/tesk-api/blob/master/src/main/java/uk/ac/ebi/tsc/tesk/k8s/config/KubernetesClientConfig.java - the alternative patch client and the patch API objects probably can be now removed and the regular client used for patching. I hope the new version of the K8s client is still thread-safe (the old one was, at least for our use cases).

lvarin commented 3 years ago

Thanks for the review, I will check the patchApiClient.