lvarin
commented
2 years ago Well, it was too good to be true. I will add the fix to the Junit and see if I can fix the errors.
The reason to add the hibernate dep is that otherwise the build was failing.
Closed lvarin closed 1 year ago
lvarin
commented
2 years ago Well, it was too good to be true. I will add the fix to the Junit and see if I can fix the errors.
The reason to add the hibernate dep is that otherwise the build was failing.
aniewielska
commented
2 years ago According to this this would be a better option:
<dependency>
<groupId>org.hibernate.validator</groupId>
<artifactId>hibernate-validator</artifactId>
</dependency>It will pull the Validator compatible with this Spring Boot (not sure of exact differences between the packaging of org.hibernate and org.hibernate.validator. I think it resolves some test errors (but not all).
aniewielska
commented
2 years ago Hi again - my last one before I switch off for a couple of weeks:
Brico87
commented
2 years ago Hey ! I allow myself jumping into that PR. Regarding the incompatibility between Springfox and boot versions, you can find a solution here: https://stackoverflow.com/questions/70036953/springboot-2-6-0-spring-fox-3-failed-to-start-bean-documentationpluginsboot/70037507#70037507.
Just do not forget to add that:
spring.mvc.pathmatch.matching-strategy=ant_path_matcherto the application.properties file. Then you can keep version 2.6.1 of boot and use 3.0.0 of Springfox
Cheers !
lvarin
commented
2 years ago Thanks to both for the help. Now the tests pass, this time hope for real :)
lvarin
commented
1 year ago Thanks, I applied all suggestions
codecov[bot]
commented
1 year ago Base: 55.52% // Head: 55.23% // Decreases project coverage by -0.28% :warning:
Coverage data is based on head (
29dad18) compared to base (27a1323). Patch coverage: 46.15% of modified lines in pull request are covered.:exclamation: Current head 29dad18 differs from pull request most recent head b1f1963. Consider uploading reports for the commit b1f1963 to get more accurate results
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Hi @lvarin - unfortunately not so easy. TESK API still has JUnit4 tests. They stop running silently in your version and give a false impression that all is good. When you add this:
to dependencies (reference here, although I expected compilation failures and not silent pass!), some tests start to fail. Another question was specific version of Hibernate Validator necessary? Always good to go with the one managed by Spring Boot, than choose your own one. The release notes look quite extensive. Not such an easy upgrade as I hoped for.