Closed lvarin closed 4 years ago
Merging #3 into master will increase coverage by
0.07%
. The diff coverage is87.50%
.
@@ Coverage Diff @@
## master #3 +/- ##
==========================================
+ Coverage 83.35% 83.42% +0.07%
==========================================
Files 35 35
Lines 913 929 +16
Branches 96 98 +2
==========================================
+ Hits 761 775 +14
Misses 108 108
- Partials 44 46 +2
Impacted Files | Coverage Δ | |
---|---|---|
...ebi/tsc/tesk/config/KubernetesObjectsSupplier.java | 92.85% <80.00%> (-2.80%) |
:arrow_down: |
...c/ebi/tsc/tesk/config/TaskmasterEnvProperties.java | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 0cc9842...845df87. Read the comment docs.
I guess this PR can be closed without merging. The workflow could get the secret key files as data files?
Actually, I wanted to use this PR as a base for global secrets for executors. That would require additional change in tesk-core, if we want to mount the secrets as volumes. But - I realised this PR brings new secrets to taskmaster and not to executors directly. I think I will just implement the change to bring secrets to executors and we will see, if this is what was needed and if this PR makes sense.
In the end the global secrets have been implemented here: https://github.com/EMBL-EBI-TSI/tesk-api/pull/5 I will close this PR without merging.
To allow mount of extra secret files in the jobs it adds:
We need this to sign/encrypt files with
crypt4gh
and upload the result usingsftp
.