elixir-cloud-aai / tesk-api

GA4GH TES API Service that translates tasks into Kubernetes Batch API calls
Apache License 2.0
7 stars 18 forks source link

Adding missing quotes #41

Closed lvarin closed 2 years ago

lvarin commented 2 years ago

This fixes the problem that was causing a 500/HTTP error.

The JSON produced was invalid due to a lack of quotes.

codecov[bot] commented 2 years ago

Codecov Report

Merging #41 (36ddb93) into master (27a1323) will decrease coverage by 0.32%. The diff coverage is 41.66%.

:exclamation: Current head 36ddb93 differs from pull request most recent head 4b9c716. Consider uploading reports for the commit 4b9c716 to get more accurate results

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
- Coverage   55.52%   55.19%   -0.33%     
==========================================
  Files          64       64              
  Lines        2064     2089      +25     
  Branches      217      223       +6     
==========================================
+ Hits         1146     1153       +7     
- Misses        787      803      +16     
- Partials      131      133       +2     
Impacted Files Coverage Δ
...ain/java/uk/ac/ebi/tsc/tesk/config/GsonConfig.java 100.00% <ø> (ø)
...sc/tesk/config/swagger/OAuth2ClientProperties.java 88.88% <ø> (ø)
...bi/tsc/tesk/k8s/config/KubernetesClientConfig.java 92.85% <ø> (ø)
.../uk/ac/ebi/tsc/tesk/k8s/constant/K8sConstants.java 85.71% <ø> (ø)
...i/tsc/tesk/k8s/convert/ExecutorCommandWrapper.java 100.00% <ø> (ø)
...sc/tesk/k8s/convert/KubernetesObjectsSupplier.java 96.61% <ø> (ø)
.../tsc/tesk/k8s/convert/TaskmasterEnvProperties.java 91.66% <ø> (ø)
.../java/uk/ac/ebi/tsc/tesk/k8s/convert/data/Job.java 88.88% <ø> (ø)
.../tsc/tesk/k8s/convert/data/SingleTaskStrategy.java 90.90% <ø> (ø)
...java/uk/ac/ebi/tsc/tesk/k8s/convert/data/Task.java 93.54% <ø> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

sgalpha01 commented 2 years ago

Yes, it is working fine now.