elixir-cloud-aai / tesk-api

GA4GH TES API Service that translates tasks into Kubernetes Batch API calls
Apache License 2.0
7 stars 18 forks source link

Add securityContext settings #46

Closed xhejtman closed 1 year ago

xhejtman commented 1 year ago

Add option to specify security context for Kubernetes pods

codecov[bot] commented 1 year ago

Codecov Report

Base: 55.23% // Head: 55.47% // Increases project coverage by +0.24% :tada:

Coverage data is based on head (a68d0b4) compared to base (0428b41). Patch coverage: 78.12% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #46 +/- ## ========================================== + Coverage 55.23% 55.47% +0.24% ========================================== Files 64 64 Lines 2091 2118 +27 Branches 223 231 +8 ========================================== + Hits 1155 1175 +20 Misses 803 803 - Partials 133 140 +7 ``` | [Impacted Files](https://codecov.io/gh/elixir-cloud-aai/tesk-api/pull/46?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-cloud-aai) | Coverage Δ | | |---|---|---| | [...sc/tesk/k8s/convert/KubernetesObjectsSupplier.java](https://codecov.io/gh/elixir-cloud-aai/tesk-api/pull/46?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-cloud-aai#diff-c3JjL21haW4vamF2YS91ay9hYy9lYmkvdHNjL3Rlc2svazhzL2NvbnZlcnQvS3ViZXJuZXRlc09iamVjdHNTdXBwbGllci5qYXZh) | `89.53% <78.12%> (-7.08%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-cloud-aai). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-cloud-aai)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

xhejtman commented 1 year ago

@lvarin any idea how to fix these build fails?

lvarin commented 1 year ago

It is complaining about:

https://github.com/elixir-cloud-aai/tesk-api/blob/3ca56c5c9b1fb9de025c5103ff260e1ae34434fb/src/test/java/uk/ac/ebi/tsc/tesk/k8s/convert/TesKubernetesConverterTest.java#L87

I am putting the link here, so I can find it later easier.

lvarin commented 1 year ago

It took me whole day, but I got the problem. I will add the suggestions to a review, but the gist of it is that:

@MockBean
private CoreV1Api coreApi;
xhejtman commented 1 year ago

I wonder why it worked before merge from master.

xhejtman commented 1 year ago

@lvarin thanks a lot! it is fixed now. so can we merge?

lvarin commented 1 year ago

I will check today or tomorrow, sorry I had no time yet.

lvarin commented 1 year ago

LGTM, it works out of the box in OpenShift (which is very picky with the security context)