Closed xhejtman closed 1 year ago
Base: 55.23% // Head: 55.47% // Increases project coverage by +0.24%
:tada:
Coverage data is based on head (
a68d0b4
) compared to base (0428b41
). Patch coverage: 78.12% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@lvarin any idea how to fix these build fails?
It is complaining about:
I am putting the link here, so I can find it later easier.
It took me whole day, but I got the problem. I will add the suggestions to a review, but the gist of it is that:
@ContextConfiguration(classes = {io.kubernetes.client.openapi.apis.CoreV1Api.class})
should be removedTesKubernetesConverterMinimalTest.java
:@MockBean
private CoreV1Api coreApi;
I wonder why it worked before merge from master.
@lvarin thanks a lot! it is fixed now. so can we merge?
I will check today or tomorrow, sorry I had no time yet.
LGTM, it works out of the box in OpenShift (which is very picky with the security context)
Add option to specify security context for Kubernetes pods