search

elixir-cloud-aai / tesk-api

GA4GH TES API Service that translates tasks into Kubernetes Batch API calls
Apache License 2.0
7 stars 18 forks source link

Configmap #47

Closed xhejtman closed 1 year ago

xhejtman commented 1 year ago

Reworked JSON_INPUT to ConfigMap instead of env variable

xhejtman commented 1 year ago

Note, this version requires configmap version of tesk-core and is not compatible with non-configmap versions.

codecov[bot] commented 1 year ago

Codecov Report

Base: 55.47% // Head: 55.82% // Increases project coverage by +0.34% :tada:

Coverage data is based on head (5b6b6f4) compared to base (a1f1c00). Patch coverage: 81.25% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #47 +/- ## ========================================== + Coverage 55.47% 55.82% +0.34% ========================================== Files 64 64 Lines 2118 2146 +28 Branches 231 233 +2 ========================================== + Hits 1175 1198 +23 - Misses 803 807 +4 - Partials 140 141 +1 ``` | [Impacted Files](https://codecov.io/gh/elixir-cloud-aai/tesk-api/pull/47?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-cloud-aai) | Coverage Δ | | |---|---|---| | [.../tsc/tesk/k8s/service/KubernetesClientWrapper.java](https://codecov.io/gh/elixir-cloud-aai/tesk-api/pull/47?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-cloud-aai#diff-c3JjL21haW4vamF2YS91ay9hYy9lYmkvdHNjL3Rlc2svazhzL3NlcnZpY2UvS3ViZXJuZXRlc0NsaWVudFdyYXBwZXIuamF2YQ==) | `55.29% <33.33%> (-0.81%)` | :arrow_down: | | [...i/tsc/tesk/k8s/convert/TesKubernetesConverter.java](https://codecov.io/gh/elixir-cloud-aai/tesk-api/pull/47?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-cloud-aai#diff-c3JjL21haW4vamF2YS91ay9hYy9lYmkvdHNjL3Rlc2svazhzL2NvbnZlcnQvVGVzS3ViZXJuZXRlc0NvbnZlcnRlci5qYXZh) | `91.30% <85.18%> (-0.73%)` | :arrow_down: | | [...uk/ac/ebi/tsc/tesk/tes/service/TesServiceImpl.java](https://codecov.io/gh/elixir-cloud-aai/tesk-api/pull/47?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-cloud-aai#diff-c3JjL21haW4vamF2YS91ay9hYy9lYmkvdHNjL3Rlc2svdGVzL3NlcnZpY2UvVGVzU2VydmljZUltcGwuamF2YQ==) | `73.97% <100.00%> (+0.73%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-cloud-aai). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-cloud-aai)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

lvarin commented 1 year ago

Look good to me, I will merge it now. (Only food for thought is that the configmaps were not deleted after the completion)