search

elixir-cloud-aai / tesk-api

GA4GH TES API Service that translates tasks into Kubernetes Batch API calls
Apache License 2.0
7 stars 18 forks source link

API hosted at off-spec location #48

Closed uniqueg closed 1 year ago

uniqueg commented 1 year ago

TESK instances are currently hosted at https://host/v1, but according to TES v1.0 and v1.1 they should be hosted at https://host/ga4gh/tes/v1 instead.

Surely this can be configured in Kubernetes by re-routing, but it may also be hardcoded in this repo. If so, it might be good to change it in accordance with the specs. Either way, the deployment instructions should be double-checked and modified if needed.

lvarin commented 1 year ago

I will take a look

lvarin commented 1 year ago

As far as I can see tesk-api already exposes its API by default in /g4agh/v1/. Like in: https://csc-tesk-noauth.rahtiapp.fi/swagger-ui.html#/TaskService

The HELM chart has a different default /v1. I will create a small PR to TESK to fix this.

uniqueg commented 1 year ago

Perfect, thanks a lot.

Merged the PR, so closing this