elixir-cloud-aai / tesk-api

GA4GH TES API Service that translates tasks into Kubernetes Batch API calls
Apache License 2.0
7 stars 18 forks source link

Fix swagger UI #51

Closed lvarin closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 50.00% and no project coverage change.

Comparison is base (df6446f) 55.82% compared to head (9df10d8) 55.82%.

:exclamation: Current head 9df10d8 differs from pull request most recent head e5d6f2f. Consider uploading reports for the commit e5d6f2f to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #51 +/- ## ======================================= Coverage 55.82% 55.82% ======================================= Files 64 64 Lines 2146 2146 Branches 233 233 ======================================= Hits 1198 1198 Misses 807 807 Partials 141 141 ``` | [Impacted Files](https://app.codecov.io/gh/elixir-cloud-aai/tesk-api/pull/51?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-cloud-aai) | Coverage Δ | | |---|---|---| | [...ava/uk/ac/ebi/tsc/tesk/tes/api/HomeController.java](https://app.codecov.io/gh/elixir-cloud-aai/tesk-api/pull/51?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-cloud-aai#diff-c3JjL21haW4vamF2YS91ay9hYy9lYmkvdHNjL3Rlc2svdGVzL2FwaS9Ib21lQ29udHJvbGxlci5qYXZh) | `50.00% <0.00%> (ø)` | | | [...k/config/security/ResourceServerConfiguration.java](https://app.codecov.io/gh/elixir-cloud-aai/tesk-api/pull/51?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-cloud-aai#diff-c3JjL21haW4vamF2YS91ay9hYy9lYmkvdHNjL3Rlc2svY29uZmlnL3NlY3VyaXR5L1Jlc291cmNlU2VydmVyQ29uZmlndXJhdGlvbi5qYXZh) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

lvarin commented 1 year ago

Ok, please push your changes

dBucik commented 1 year ago

As I am not allowed to push directly into this repo, I have created a new PR - please see #52

lvarin commented 1 year ago

I double checked. It works for me:

https://csc-tesk-noauth2.rahtiapp.fi/swagger-ui/index.html

What exactly does not work for you? Is it the building process or Swagger's UI?

martin-kuba commented 1 year ago

SpringFox is not maintained, I recommend moving to SpringDoc OpenAPI, see https://springdoc.org/#migrating-from-springfox

lvarin commented 1 year ago

Upgrading to springdoc requires redoing the Oauth implementation/configuration.

I have work on this for a couple of days and the amount of changes needed is too much for me. I have no knowledge or time to do this.

SpringFox is not maintained, I recommend moving to SpringDoc OpenAPI, see https://springdoc.org/#migrating-from-springfox

Indeed there are no changes since 3 years ago. So leaving this project as it is now is not an option.

lvarin commented 1 year ago

Just to add to the pile of problems:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.10.1:compile (default-compile) on project tesk: Compilation failure
[ERROR] /home/galvaro/src/tesk-api/src/main/java/uk/ac/ebi/tsc/tesk/config/swagger/SwaggerConfigAuth.java:[8,33] cannot access org.springdoc.core.models.GroupedOpenApi
[ERROR]   bad class file: /home/galvaro/.m2/repository/org/springdoc/springdoc-openapi-starter-common/2.2.0/springdoc-openapi-starter-common-2.2.0.jar(org/springdoc/core/models/GroupedOpenApi.class)
[ERROR]     class file has wrong version 61.0, should be 52.0
[ERROR]     Please remove or make sure it appears in the correct subdirectory of the classpath.

springdoc only works with Java 17 or newer. Tesk-api is written for Java v1.8

lvarin commented 1 year ago

From what we talked F2F, we should add a 3rd person to test this PR using the deprecated framework, merge it if successful and then put the effort on a python3 migration

trispera commented 1 year ago

I just tested this PR. Everything worked fine for me

We can merge