elixir-cloud-aai / tesk-api

GA4GH TES API Service that translates tasks into Kubernetes Batch API calls
Apache License 2.0
7 stars 18 forks source link

refactor: 💡 Update to new version of Springfox #52

Closed dBucik closed 9 months ago

lvarin commented 1 year ago

At a first glance, this PR has too many unrelated changes. Some of the changes seem to remove examples for Swagger, others add new classes and includes.

I will instead work on the original PR to check why it does work for my environment and not in yours.

lvarin commented 1 year ago

This branch does not pass the tests:

(...)
[INFO] 
[INFO] Results:
[INFO] 
[ERROR] Failures: 
[ERROR]   TesKubernetesConverterMinimalTest.fromTesTaskToK8sConfigMap:187 JSON Comparison failure: 
Unexpected: state

[ERROR]   TesKubernetesConverterTest.fromTesTaskToK8sConfigMap:259 JSON Comparison failure: 
Unexpected: state

[ERROR]   TasksApiControllerTest.createTask_invalid_executors:106 Range for response status value 200 expected:<CLIENT_ERROR> but was:<SUCCESSFUL>
[ERROR]   TasksApiControllerTest.createTask_invalid_inputs:125 Range for response status value 200 expected:<CLIENT_ERROR> but was:<SUCCESSFUL>
[ERROR]   TasksApiControllerTest.createTask_invalid_outputs:144 Range for response status value 200 expected:<CLIENT_ERROR> but was:<SUCCESSFUL>
[ERROR]   TasksApiControllerTest.createTask_invalid_volumes:161 Range for response status value 200 expected:<CLIENT_ERROR> but was:<SUCCESSFUL>
[ERROR] Errors: 
[ERROR]   TesKubernetesConverterMinimalTest.fromK8sToTask_cancelled:237->prepareBaseExpectedTask:206 » ValueInstantiation
[ERROR]   TesKubernetesConverterMinimalTest.fromK8sToTask_complete:214->prepareBaseExpectedTask:206 » ValueInstantiation
[ERROR]   TesKubernetesConverterMinimalTest.fromK8sToTask_executor_error:320->prepareBaseExpectedTask:206 » ValueInstantiation
[ERROR]   TesKubernetesConverterMinimalTest.fromK8sToTask_initializing:330->prepareBaseExpectedTask:206 » ValueInstantiation
[ERROR]   TesKubernetesConverterMinimalTest.fromK8sToTask_list:225->prepareBaseExpectedTask:206 » ValueInstantiation
[ERROR]   TesKubernetesConverterMinimalTest.fromK8sToTask_queued_executor:267->prepareBaseExpectedTask:206 » ValueInstantiation
[ERROR]   TesKubernetesConverterMinimalTest.fromK8sToTask_queued_taskmaster:257->prepareBaseExpectedTask:206 » ValueInstantiation
[ERROR]   TesKubernetesConverterMinimalTest.fromK8sToTask_running:247->prepareBaseExpectedTask:206 » ValueInstantiation
[ERROR]   TesKubernetesConverterMinimalTest.fromK8sToTask_system_error_filer:309->prepareBaseExpectedTask:206 » ValueInstantiation
[ERROR]   TesKubernetesConverterMinimalTest.fromK8sToTask_system_error_mismatch:297->prepareBaseExpectedTask:206 » ValueInstantiation
[ERROR]   TesKubernetesConverterMinimalTest.fromK8sToTask_system_error_no_executors:286->prepareBaseExpectedTask:206 » ValueInstantiation
[ERROR]   TesKubernetesConverterMinimalTest.fromK8sToTask_system_error_no_state:276->prepareBaseExpectedTask:206 » ValueInstantiation
[INFO] 
[ERROR] Tests run: 104, Failures: 6, Errors: 12, Skipped: 0
[INFO] 
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 22.910 s
[INFO] Finished at: 2023-08-29T14:42:34+03:00
[INFO] Final Memory: 59M/729M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.22.1:test (default-test) on project tesk: There are test failures.
[ERROR] 
[ERROR] Please refer to /home/galvaro/src/tesk-api/target/surefire-reports for the individual test results.
[ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

with command: $ ./mvnw clean verify