search

elixir-cloud-aai / tesk-api

GA4GH TES API Service that translates tasks into Kubernetes Batch API calls
Apache License 2.0
7 stars 18 forks source link

fix Sets the requests equals to limits. #57

Closed lvarin closed 3 months ago

lvarin commented 3 months ago

Summary by Sourcery

Set CPU limits in Kubernetes container resources to match CPU requests and update tests to verify this behavior.

Bug Fixes:

Tests:

sourcery-ai[bot] commented 3 months ago

Reviewer's Guide by Sourcery

This pull request adds functionality to set CPU limits in the Kubernetes container resources. Tests have been updated to verify that the CPU limits are correctly set to 4 for all executors. Additionally, a JSON comparison test has been commented out.

File-Level Changes

Files Changes
src/test/java/uk/ac/ebi/tsc/tesk/k8s/convert/TesKubernetesConverterTest.java
src/test/resources/fromTesToK8s/taskmaster_param.json		 Updated tests to include checks for CPU limits in the container resources.
src/main/java/uk/ac/ebi/tsc/tesk/k8s/convert/TesKubernetesConverter.java Implemented setting of CPU limits in the Kubernetes container resources.
Tips - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - Continue your discussion with Sourcery by replying directly to review comments. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.