elixir-cloud-aai / tesk-api

GA4GH TES API Service that translates tasks into Kubernetes Batch API calls
Apache License 2.0
7 stars 18 forks source link

Make task-master and task-filer images configurable #8

Closed ghost closed 4 years ago

ghost commented 4 years ago

Hey,

I would like to use a Cromwell server as a front for TESK and it seems that the way Cromwell submits tasks to TESK is not in accordance to what TESK requires in terms of file down- and upload. Hence, I changed some minor things in the task-filer and task-manager to adjust it to my needs/Cromwell's output. However, I need to change the images used by the tesk-api in order to validate that it works. I was wondering if you could set up env variables for the images used in order to allow me to use custom images.

aniewielska commented 4 years ago

Hello, 1) TBH we never tried Cromwell with TESK and shared filesystem. Options that work:

I will keep this issue open and close it, once changing images has been made available.

ghost commented 4 years ago

Thank you for getting back to me so fast. I set TESK_API_TASKMASTER_IMAGE_NAME to the image I want to test and it works fine. I also changed the default image of the filer in the taskmaster and it uses the test image. I will see if I get it to work and get back to you. 😃

aniewielska commented 4 years ago

The PR #6 has been accepted and now it should be possible to change both images - taskmaster and filer, starting with this release. I added some more information to docs