search

elixir-cloud-aai / tesk-api

GA4GH TES API Service that translates tasks into Kubernetes Batch API calls
Apache License 2.0
7 stars 18 forks source link

Quick and dirty fix to scientific notation problem #9

Closed lvarin closed 4 years ago

lvarin commented 4 years ago

Quick and dirty fix, to the scientific notation and too memory low problems.

It took a while to find the spot, but it fixes both bugs. Kubernetes does not like in the memory specification of the Pod, the scientific notation format JAVA uses. This code could be improved by, using the API to get the current minimum and maximum memories, convert the memory value to the memory unit that suits better, i.e.: 0.1 GiB should be ~100MiB.

codecov[bot] commented 4 years ago

Codecov Report

Merging #9 into master will decrease coverage by 0.10%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
- Coverage   83.92%   83.81%   -0.11%     
==========================================
  Files          37       37              
  Lines         964      964              
  Branches      101      101              
==========================================
- Hits          809      808       -1     
  Misses        107      107              
- Partials       48       49       +1
Impacted Files Coverage Δ
...sc/tesk/util/component/TesKubernetesConverter.java 89.62% <0.00%> (-0.75%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5c2ff14...150554b. Read the comment docs.