search

elixir-cloud-aai / tesk-core

Python code that is launched as images into the Kubernetes cluster by tesk-api.
Apache License 2.0
2 stars 13 forks source link

feat(api): variable jobs backoff limits #22

Closed stikos closed 4 years ago

stikos commented 4 years ago

The number of retries before considering a K8s job as failed (see this) can now be explicitly set through the following 2 environment variables for executor and filer jobs, respectively:

codecov-commenter commented 4 years ago

Codecov Report

Merging #22 into master will decrease coverage by 0.27%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
- Coverage   27.55%   27.28%   -0.28%     
==========================================
  Files           8        8              
  Lines         606      612       +6     
==========================================
  Hits          167      167              
- Misses        439      445       +6
Impacted Files Coverage Δ
src/tesk_core/filer_class.py 0.00% <0.00%> (ø)
src/tesk_core/taskmaster.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update acebd70...c9ec8b4. Read the comment docs.

aniewielska commented 4 years ago

Thanks for contributing. Unfortunately it did not want to work e2e. Issue 1: While passing env vars to taskmaster, api strips TESK_API_TASKMASTER_ENVIRONMENT_ prefix. I forgot about it and actually, that needs to be specified in the docs as well. Issue 2: K8s unfortunately expects all env vars as Strings. So conversion to int was necessary.