search

elixir-cloud-aai / tesk-core

Python code that is launched as images into the Kubernetes cluster by tesk-api.
Apache License 2.0
2 stars 13 forks source link

S3 feature #28

Closed cibinsb closed 4 years ago

cibinsb commented 4 years ago

Extending the tesk core functionality to only allow file/directory download from s3 using boto3.

codecov-commenter commented 4 years ago

Codecov Report

Merging #28 into master will increase coverage by 2.67%. The diff coverage is 91.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
+ Coverage   79.59%   82.26%   +2.67%     
==========================================
  Files           9       11       +2     
  Lines         686      795     +109     
==========================================
+ Hits          546      654     +108     
- Misses        140      141       +1
Impacted Files Coverage Δ
src/tesk_core/filer_class.py 77.77% <ø> (-0.49%) :arrow_down:
src/tesk_core/transput.py 84.12% <84.12%> (ø)
src/tesk_core/filer.py 81.29% <92.85%> (+0.47%) :arrow_up:
src/tesk_core/filer_s3.py 96.90% <96.90%> (ø)
src/tesk_core/extract_endpoint.py 100.00% <0.00%> (+11.11%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4fa38ff...93ba1e2. Read the comment docs.

cibinsb commented 4 years ago

Updated, please review.

cibinsb commented 4 years ago

Please review.

cibinsb commented 4 years ago

Please review.

aniewielska commented 4 years ago

Now this PR has quite a lot of conflicts. Please try to rebase your changes on top of master, resolving conflicts. There might be changes that are in 2 places (extract_endpoint), so please leave only one copy. Also filer_class is definitely not the place for Transput class. It is used for something completely different (constructing Filer Job object) and so far has not at all bean invoked in the context of filer script.