search

elixir-cloud-aai / tesk-core

Python code that is launched as images into the Kubernetes cluster by tesk-api.
Apache License 2.0
2 stars 13 forks source link

Testing Job.py #30

Closed cibinsb closed 4 years ago

cibinsb commented 4 years ago

Updating the unit test cases for job.py

Changes made

  1. Increased the pod timeout check to 10 mins.
  2. Testcase to check the status of the running pod.
  3. Added test case to check the status of pod when the pod failed with a reason other than ImagePullErr
codecov-commenter commented 4 years ago

Codecov Report

Merging #30 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #30   +/-   ##
=======================================
  Coverage   79.25%   79.25%           
=======================================
  Files           8        8           
  Lines         670      670           
=======================================
  Hits          531      531           
  Misses        139      139

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b77f77c...3524f9e. Read the comment docs.

cibinsb commented 4 years ago

Updated, please review it again.

cibinsb commented 4 years ago

Changed the less meaning full code comments and method names. Please review it again.

aniewielska commented 4 years ago

There is one more thing that is annoying for a contributor. The test: tests/test_job.py::JobTestCase::test_run_to_completion_success takes too long to complete. Please, decrease a polling interval for the test, as otherwise it is 30s wait. After that, please rebase the PR on top of master and squash commits.