elixir-cloud-aai / trs-filer

Lightweight, flexible Flask/Gunicorn-based GA4GH TRS implementation
Apache License 2.0
8 stars 6 forks source link

Improve the route/ingress selection. Adds icon #112

Closed lvarin closed 4 months ago

lvarin commented 4 months ago

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

Checklist:

Summary by Sourcery

This pull request enhances the route and ingress selection logic by using API version checks, updates the host name and image source in the deployment values, and adds an icon to the Helm chart metadata.

sourcery-ai[bot] commented 4 months ago

Reviewer's Guide by Sourcery

This pull request improves the route and ingress selection logic in the Helm chart for the trs-filer application and adds an icon to the Chart.yaml file. The changes ensure compatibility with different Kubernetes environments by checking for API version capabilities instead of relying on a cluster type variable.

File-Level Changes

Files Changes
deployment/values.yaml
deployment/templates/trs-filer-route.yaml
Improved the route and ingress selection logic by checking for API version capabilities instead of relying on a cluster type variable.
deployment/Chart.yaml Added an icon to the Chart.yaml file and updated the chart version.

Tips - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - Continue your discussion with Sourcery by replying directly to review comments. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.