elixir-cloud-aai / trs-filer

Lightweight, flexible Flask/Gunicorn-based GA4GH TRS implementation
Apache License 2.0
8 stars 6 forks source link

Bug in file registration #68

Closed uniqueg closed 4 years ago

uniqueg commented 4 years ago

When registering files of different descriptor types (e.g., CWL and WDL), the tool file (and maybe the file wrapper) objects for all files (e.g., CWL files and WDL files) are stored underneath each of the descriptors.

Specifically, I used PUT /tools/{id} to store a workflow with four files, one PRIMARY_DESCRIPTOR each for CWL and WDL, a SECONDARY_DESCRIPTOR file for CWL and an OTHER file for WDL, so two files per workflow. Then hitting the GET .../{type}/files endpoint for both type CWL and WDL returned all 4 files. The GET .../{type}/descriptor endpoint seemed to give the right response for each type.

To do:

uniqueg commented 4 years ago

Fixed by https://github.com/elixir-cloud-aai/trs-filer/commit/c9d37ed76999941baaae34ddc2c96fb83064f090