Update csv_encoder.ex - Githubissues

elixir-crawly / crawly

Crawly, a high-level web crawling & scraping framework for Elixir.

https://hexdocs.pm/crawly

Apache License 2.0

965 stars 113 forks source link

Update csv_encoder.ex #201

Closed jack-s9 closed 1 year ago

jack-s9 commented 2 years ago

Add code formatting around iex example for Crawly.Pipelines.CSVEncoder docs

Ziinc commented 2 years ago

@jack-s9 thanks for the fix, code indentation does not actually require backticks, see here https://hexdocs.pm/elixir/1.13/writing-documentation.html

could you remove the backticks and add in the additional line after the header? i think the parser requires a newline.

Checks are failing are on me, will fix. thanks for contrib!

jack-s9 commented 2 years ago

I made the change to remove the backticks. I'm pushing changes from the GitHub web interface and wasn't sure how to squash my commits. Let me know if you need any other changes.

oltarasenko commented 2 years ago

Hey. As far as I see, it failed on --check-formatted step. Could you please format the code so I can merge it? @jack-s9

Ziinc commented 2 years ago

@oltarasenko coveralls uploading doesn't work for PRs, for some reason.