elixir-crawly / crawly

Crawly, a high-level web crawling & scraping framework for Elixir.
https://hexdocs.pm/crawly
Apache License 2.0
976 stars 115 forks source link

Implement String.Chars for Crawly.Request #217

Closed fstp closed 2 years ago

fstp commented 2 years ago

To enable the requests to be written to file/log (for example in the WriteToFile pipeline) the String.Chars protocol is implemented as a trivial Kernel.inspect dump.

Ziinc commented 2 years ago

Hi thanks for the contribution, could you add in a test for this so that I can verify on my side the error that you mentioned in the closed PR?

fstp commented 2 years ago

Sorry for the late response, sure I will add a testcase for it :)