search

elixir-ecto / db_connection

Database connection behaviour
http://hexdocs.pm/db_connection/DBConnection.html
306 stars 113 forks source link

Ownership pool can not start Sojourn pool #106

Closed fishcakez closed 6 years ago

fishcakez commented 6 years ago

The Ownership pool starts its internal pool via the Watcher, and Sojourn starts its internal pool via the Watcher. The Watcher blocks when starting an internal pool so can't receive the request from Sojourn to start its internal pool as it blocking starting the Sojourn pool itself (Ownership's internal pool).

josevalim commented 6 years ago

FWIW, I am completely fine with saying we only work with poolboy if fixing it is going to be a big hassle.

fishcakez commented 6 years ago

I am happy to force poolboy too. This isn't an issue for Ecto because poolboy will always be there.

michalmuskala commented 6 years ago

:+1: for ownership pool working only with poolboy. Should we remove the ability to specify the "inner" pool for ownership pool altogether?

michalmuskala commented 6 years ago

I will close the issue given we'll be moving away from poolboy and sojurn in 2.0. This is tracked in https://github.com/elixir-ecto/db_connection/pull/108