search

elixir-ecto / db_connection

Database connection behaviour
http://hexdocs.pm/db_connection/DBConnection.html
309 stars 112 forks source link

Add a way to disable connect exception sanitisation #120

Closed michalmuskala closed 6 years ago

michalmuskala commented 6 years ago

It sometimes might be problematic when all details of exceptions are erased and once tries to debug some issue. I agree that the sanitisation should be there by default, but it should be possible to disable it with an option during a debugging session.

fishcakez commented 6 years ago

I think we can improve the message instead or as well. The exception type and stacktrace is still there so likely they can debug but because it says information was removed they get lazy.

fishcakez commented 6 years ago

I take that comment partially back we should allow users to get best error possible :), though we can encourage them to debug by also improving the sanitization message.

michalmuskala commented 6 years ago

I think we should have a enable_unsafe_errors setting or something like that. Additionally when it's set we should print a warning.

josevalim commented 6 years ago

Closing in favor of #161.