search

elixir-ecto / db_connection

Database connection behaviour
http://hexdocs.pm/db_connection/DBConnection.html
309 stars 112 forks source link

DBConnection.run should fail if the connection state before and after are not the same #122

Closed josevalim closed 6 years ago

josevalim commented 6 years ago

The question is if we should ALWAYS do this or only on certain cases.

fishcakez commented 6 years ago

This is a tricky one, it might be we should provide the functions and drivers build their own run from lower level functions. Currently every function called in the context of a run except transaction functions. This would no longer map as we only care about the checkout -> checkin change

josevalim commented 6 years ago

For now we are inclined to do this on the side. But we still need to check the disconnect behaviour with status.

josevalim commented 6 years ago

CLosing in favor of #145.