search

elixir-ecto / db_connection

Database connection behaviour
http://hexdocs.pm/db_connection/DBConnection.html
306 stars 113 forks source link

Use optional_callbacks instead of relying on default implementations #124

Closed josevalim closed 6 years ago

josevalim commented 6 years ago

This commit also moves the handling of replies to each callback instead of a main handle function as otherwise we would need to push function_exported?/3 concerns into it.

josevalim commented 6 years ago

@fishcakez I am struggling to remove handle_info. So I want to merge this as is and then add a note to remove the handle_info callback in another PR. :)

fishcakez commented 6 years ago

Ok lets merge this then. Lets remove poolboy and connection before we remove handle_info.