search

elixir-ecto / db_connection

Database connection behaviour
http://hexdocs.pm/db_connection/DBConnection.html
309 stars 112 forks source link

Add more logging for ownership errors. #128

Closed scouten closed 6 years ago

scouten commented 6 years ago

This PR attempts to address a challenge with the difficult-to-debug (DBConnection.ConnectionError) owner #PID<...> exited while client #PID<...> is still running error. (Which code started that connection? The error message doesn't give sufficient context to answer that question, so the warning is rarely actionable.)

With this PR the stack trace from the code that checks out the connection is retained and added to the error message should there be an unexpected exit.

Consider this more of a rough draft of a PR. I am concerned about the overhead involved and think that it might be a good idea to add an explicit opt-in config option to enable this tracking.

josevalim commented 6 years ago

Thanks @scouten! This is a great idea, I like this a lot. I think we can do like GenServer and use Process.info(pid, :current_stacktrace) to get the information both of the checkout process and the one that is still running. This way we can do it only for ownership (which is mostly for tests). I am currently reworking the ownership pool so I will make sure to revisit this.

josevalim commented 6 years ago

Closing in favor of #135.