search

elixir-ecto / db_connection

Database connection behaviour
http://hexdocs.pm/db_connection/DBConnection.html
309 stars 112 forks source link

Remove handle_info #133

Closed josevalim closed 6 years ago

josevalim commented 6 years ago

@fishcakez what is the rationale to remove handle_info?

Supporting it is straight-forward and if we remove it one of our examples (TCP connections) will no longer work.

fishcakez commented 6 years ago

@josevalim we no longer call it, so the example should be broken. Sockets are forced to be passive. This means we should be able to remove checkout/1 and checkin/1 as they would be no-ops.

josevalim commented 6 years ago

Closing in favor of #134