elixir-ecto / db_connection

Database connection behaviour
http://hexdocs.pm/db_connection/DBConnection.html
306 stars 113 forks source link

Add :ping_timeout option #189

Closed wojtekmach closed 5 years ago

wojtekmach commented 5 years ago

Ref: https://github.com/elixir-ecto/myxql/issues/38#issuecomment-459985140

This is WIP and it's missing docs & tests. It also fails the build as the integration test expects that ping callback is executed in the very same process as connect callback is.

@fishcakez some guidance would be appreciated! Should I look into timers and using DBConnection.Task.start_child as we're doing with after_connect?

josevalim commented 5 years ago

Closing this due to the complexity and the fact implementation on the socket side is trivial.