Closed whatyouhide closed 1 year ago
@whatyouhide make sure that you run the integration tests in ecto_sql
. :)
Looks fantastic. But note CI fails. :) And yeah, maybe it is simpler to not update connection
indeed, so we keep it "stable".
@josevalim fixed the bug, now mix test.all
passes here. Will try the integration tests in ecto_sql
.
@whatyouhide can you check CI? is_exception is not available, you will have to pattern match. :)
Oooph yeah, I stopped checking because it was giving trouble with Erlang/Elixir versions yesterday, and I thought it was still that. Fixed now.
:green_heart: :blue_heart: :purple_heart: :yellow_heart: :heart:
Just started on this but all tests pass 🙃 I also tried this branch out in ecto_sql and all tests pass there too. I'll see if I can try it in Postgrex maybe.