search

elixir-ecto / db_connection

Database connection behaviour
http://hexdocs.pm/db_connection/DBConnection.html
309 stars 112 forks source link

Add DBConnection.available_connection_options/0 #291

Closed whatyouhide closed 1 year ago

whatyouhide commented 1 year ago

Follow up to #290.

josevalim commented 1 year ago

available_connection_options perhaps?

whatyouhide commented 1 year ago

@josevalim the type is called DBConnection.option/0, and these are passed to basically all DBConnection functions, so I’m not sure... 😕

josevalim commented 1 year ago

It seems most of our specs use Keyword.t()? Should we align that instead then? But if we are doing that, I would prefer to call it t:DBConnection.connection_options to avoid ambiguity?

whatyouhide commented 1 year ago

@josevalim yeah, the type is there but not really used. If you want, we can add t:DBConnection.connection_option/0, deprecate t:DBConnection.option/0, and change specs to use DBConnection.connection_option/0. Thoughts?

josevalim commented 1 year ago

Sure!

whatyouhide commented 1 year ago

@josevalim done.

josevalim commented 1 year ago

:green_heart: :blue_heart: :purple_heart: :yellow_heart: :heart: