Add metrics for connection pool usage (tests speed up + checkin metrics bugfix)

elixir-ecto / db_connection

Database connection behaviour

http://hexdocs.pm/db_connection/DBConnection.html

309 stars 112 forks source link

Add metrics for connection pool usage (tests speed up + checkin metrics bugfix) #306

Closed kor-and-m closed 5 months ago

kor-and-m commented 6 months ago

Hello @josevalim, I'm highly motivated to complete the pull request could you take a look at it please?

josevalim commented 6 months ago

Thank you for the PR.

Shouldn't be able to get these metrics from querying the ETS table? We are either with connections in the pools or with pending requests, the mode tells if we are busy or ready. :)

Also, could we reuse the existing testing infrastructure somehow? Or do we need to define new DBs and new Pools?