search

elixir-ecto / db_connection

Database connection behaviour
http://hexdocs.pm/db_connection/DBConnection.html
306 stars 113 forks source link

Use Rand module over depreciated Random module #53

Closed mdoza closed 8 years ago

mdoza commented 8 years ago

Erlang's Random module is deprecated from 19.0. Using the Rand module is now encouraged.

fishcakez commented 8 years ago

DBConnection will use :rand when :rand is available, otherwise fallback to :random. The :random.seed/3 call here must use :random.seed/3 to create a valid seed when using :random.

fishcakez commented 8 years ago

Ah, I am sorry, I now understand this was trying to remove a compile time warning hard coded into Erlang compiler. I have disabled the warning with https://github.com/elixir-ecto/db_connection/commit/66e6e7b36638d95145e1b4c63371eadf02226e0a.

mdoza commented 8 years ago

@fishcakez understood. Yes, that'll fix it. Thanks.