elixir-ecto / db_connection

Database connection behaviour
http://hexdocs.pm/db_connection/DBConnection.html
309 stars 112 forks source link

Switch to non-closure based transactions #87

Closed fishcakez closed 7 years ago

fishcakez commented 7 years ago

Requiring a fun for a transaction and non-local return for a rollback is a very limiting API. With this breaking change the API becomes more flexible, in particular it allows transaction to continue over multiple OTP behaviour callbacks and use of (potentially nested) savepoints.

Removes:

Adds:

josevalim commented 7 years ago

Do we need all 8 new functions? I assume the last three are for convenience?

fishcakez commented 7 years ago

Closed in a favour of #88 #89 #90