search

elixir-ecto / ecto_sql

SQL-based adapters for Ecto and database migrations
https://hexdocs.pm/ecto_sql
Apache License 2.0
558 stars 312 forks source link

make Ecto.Adapters.SQL.with_log/3 public #615

Closed ruslandoga closed 3 months ago

ruslandoga commented 3 months ago

In place of https://github.com/elixir-ecto/ecto_sql/pull/614

This PR makes it easier to implement custom functions in adapters by making Ecto.Adapters.SQL.with_log/3 public.

josevalim commented 3 months ago

Between the two changes, I would prefer to make query accept a map. :) with_log is really internal and depends on internal fields like telemetry, that I don't feel very comfortable in exposing. Sorry :)