elixir-editors / emacs-elixir

Emacs major mode for Elixir
446 stars 94 forks source link

Customizable face for numbers #459

Closed jsmestad closed 3 years ago

jsmestad commented 4 years ago

Background

I had made a patch to doom-emacs (see hlissner/doom-emacs#3613) to highlight 10_000 correctly after the Elixir formatter had run. As a next step, I wanted to have this functionality built into emacs-elixir mode for those who want to customize how numbers show up.

While I was in there, I did some general cleanup based on best practices and the Emacs Lisp docs.

Changes

Discussion

Is default appropriate?

jsmestad commented 4 years ago

I changed up the test matrix as it was failing on Emacs 24.5 (same with master).

Looking around at other major modes, most have moved up to a minimum support of Emacs 26.3, so I did the same. I wanted to test Emacs 27.1 and Emacs 28.0.50, but EVM lacks support for these releases at the moment.

jsmestad commented 3 years ago

@Trevoke and @victorolinasc I rolled back all the attempted CI fixes. Please take a look when you get the time 👍