search

elixir-editors / emacs-elixir

Emacs major mode for Elixir
446 stars 94 forks source link

elixir-format: unquote file names #479

Closed listx closed 1 year ago

listx commented 2 years ago

This fixes a breakage if the file name happens to be already quoted, as per https://www.gnu.org/software/emacs/manual/html_node/emacs/Quoted-File-Names.html. If the file name is not quoted, it is the same as the old behavior.

victorolinasc commented 2 years ago

It seems that file-name-unquote is introduced only in Emacs 26.1. This would break running the format on 25.

Is this breaking anything special for yourself? I don't see other modes using this so that is why I ask :)

Thanks for your contribution!

listx commented 2 years ago

It seems that file-name-unquote is introduced only in Emacs 26.1. This would break running the format on 25.

Oh that is unfortunate.

Is this breaking anything special for yourself? I don't see other modes using this so that is why I ask :)

I use the file quoting prefix /: when opening file from the CLI as an argument to emacsclient, so that's why I run into this. I guess it's something I can just define an advice around it for myself so there's no rush for this to merge at all.

victorolinasc commented 1 year ago

Hi @listx ! If you still want this to be merged, we'd need to add the compat library. With that we can call the file-name-unquote function.

I will close this for now. If you still need this, please open a new PR with the compat and a test so that we can merge it :)

Thanks!