elixir-editors / language-elixir

Elixir language support for the Atom editor.
Other
181 stars 40 forks source link

Indent Guide is misaligned with invisibles turned on #108

Closed mstewart6 closed 6 years ago

mstewart6 commented 6 years ago

invisibles

When using the indent guide with invisibles turned on, the guide lines get misaligned when blank lines surround non-blank lines. The guide lines get shifted over by 1px to the right for the guides with invisibles (see attached picture for reference).

Switching between themes when the grammar is set to Elixir does not resolve this, but changing the grammar to the default grammar (Plain Text) does, so it appears to be something related to this language package. Turning off invisibles also causes the guide lines to re-align properly.

keathley commented 6 years ago

@mstewart6 I'm not able to see this issue on my machine. Are you using a specific font that may be doing this?

Here's what I'm seeing on my machine:

screen shot 2018-10-05 at 10 33 23 am
mstewart6 commented 6 years ago

@keathley No, I am using the default font. I have my font as size 13 (but I dropped it to the default as well to no effect). Using OSX 10.13 High Sierra, if platform matters.

The issue isn't with consecutive lines with spaces, it's when a completely blank line is adjacent to one with leading spaces. It is possible that it only affects heredocs, as that is where I am most consistent in reproducing it.

image

keathley commented 6 years ago

Same setup, with default font size set to 13:

image

Have you tried disabling different packages to see if that effects this?

mstewart6 commented 6 years ago

Aha, looks like there is a fonts package for monospace fonts that was causing this (but only for Elixir oddly). Disabling that makes everything look correct again.

Note that your latest repro does not have blank lines surrounding the indented one though. The lack of spaces was what was triggering it for me, though it now appears that the font package was to blame.

keathley commented 6 years ago

Ah I see. I think I've matched yours now:

image.

In any case it sounds like its an issue with the fonts package. I'd open an issue up with them :+1:.