search

elixir-editors / language-elixir

Elixir language support for the Atom editor.
Other
181 stars 40 forks source link

Short `do:` block is not properly highlighted #67

Closed armed closed 8 years ago

armed commented 8 years ago

do: with semicolon is highlighted as map/keyword key:

screen shot 2016-06-05 at 3 01 27 pm
nii236 commented 8 years ago

The indentation also does work on a newline if you use do instead of do:

keathley commented 8 years ago

@armed: I'm not sure that this is a bug. In this case the do is a keyword. Should we have a special case for do: as a keyword? My gut feeling is that we shouldn't.

@nii236: I'll take a look at this.

nii236 commented 8 years ago

@keathley: Thanks! I added two gifs comparing vim and atom for your reference.

Vim

elixir_vim

Atom

elixir_atom

armed commented 8 years ago

@keathley I got your point, but what confused me is that before commit 264ffbf528fcb3129c191d60d8aa22b6770d3449 do: along with do was highlighted as other keywords.

edit:

@nii236, I agree with @keathley's opinion, so this issue may be closed if there is no more questions.

nii236 commented 8 years ago

That's fine, I'll make a new issue

keathley commented 8 years ago

@armed Sorry for the confusion. I wish there was a better way to communicate these sorts of changes so people aren't surprised by them. It would be cool if atom pulled in release notes or something similar.