search

elixir-editors / language-elixir

Elixir language support for the Atom editor.
Other
181 stars 40 forks source link

Revert doc snippets not to use backspace characters #73

Closed ymtszw closed 8 years ago

ymtszw commented 8 years ago

See https://github.com/elixir-lang/language-elixir/issues/68

keathley commented 8 years ago

This looks good to me. Before I merge it I was wondering if it might make more sense to expand the snippet to something like this:

@doc """ <- put the cursor right here
"""

That way the user simply needs to hit return to start a new line (which will then be indented correctly). Its not something that has to be a part of this PR. Just wanted to get some feedback on the idea.

ymtszw commented 8 years ago

That looks more than OK, actually. And it's easy to achieve:

  'doc':
    'prefix': 'doc'
    'body': '@doc """$0\n"""'

This will do just the thing.

I'm fine with the change, shall I push this?

keathley commented 8 years ago

I think that works great. Lets make sure that it works the same way for doc and moduledoc and it should be good :+1:

ymtszw commented 8 years ago

2d842fc Change applied

keathley commented 8 years ago

Sorry about the delay. This looks good to me. Thanks for taking care of this :tada: