search

elixir-editors / language-elixir

Elixir language support for the Atom editor.
Other
181 stars 40 forks source link

Add unused and wildcard variables #79

Closed ricmarinovic closed 7 years ago

ricmarinovic commented 8 years ago

Based on #66.

Added selectors to unused variables and the single underscore while keeping the comment selector.

It also matches unused variables ending in exclamation and question mark.

keathley commented 7 years ago

Thanks for this @rkma. The code looks great. But I feel like stylistically, highlighting unused variables as variable.other draws a lot more attention to the unused variable itself. For instance this is what my editor looks like with your PR:

screenshot 2016-10-16 13 46 21

And with the One Dark theme:

screenshot 2016-10-16 13 46 37

One of the reasons that the comment selector was originally used was because unused variables by their nature shouldn't draw your eye. Was there a specific reason that you needed this change?

ricmarinovic commented 7 years ago

I thought it would give more context, but I didn't realize it would break depending on the theme, haha. I will change that and remove variable.other.

keathley commented 7 years ago

Sorry about the confusion. This looks great thanks 👍