search

elixir-editors / language-elixir

Elixir language support for the Atom editor.
Other
181 stars 40 forks source link

Handle escaped characters inside string and charlist atoms #96

Closed rgreenjr closed 7 years ago

rgreenjr commented 7 years ago

This pull request fixes an issue introduced in a0824b9 that caused syntax highlighting to break on certain strings and charlists. Specifically, strings containing an escaped double quote followed by a semicolon "\": " and charlists containing an escaped single quote followed by a semicolon '\': '.

single_broken double_broken

The files now render as:

single_fixed double_fixed

rgreenjr commented 7 years ago

I should have added that this PR includes new tests that verify behavior.

ymtszw commented 7 years ago

This looks working great! Thanks for picking up the case :heart:

rgreenjr commented 7 years ago

@ymtszw Thanks, it's my pleasure to help. 👍