search

elixir-error-tracker / error-tracker

🐛 An Elixir-based built-in error reporting and tracking solution
https://hex.pm/packages/error_tracker
Apache License 2.0
383 stars 17 forks source link

Support for LiveView 1.0.0 RC #80

Closed grahac closed 1 month ago

grahac commented 1 month ago

Any way you can support the liveview 1.0.0 versions?

Thx!

grahac commented 1 month ago

Note: i am pretty sure it will just work but your library is restricting it haha.

odarriba commented 1 month ago

We've checked it and it currently expects LiveView ~> 0.19 or ~> 1.0, so it is prepared for the stable release of LiveView 1.0.

However, that does not apply to LiveView 1.0.0-rc.X, as that is a release candidate and you must specify that you allow RCs on the spec. I checked some other libraries and it looks like the general approach is to not specify RC versions, as that would require patching the spec now and patching it later.

I think the best solution for now is to use:

{:phoenix_live_view, "1.0.0-rc.6", override: true}

to override the requirements of our spec, and test it with the RC as you expect.

grahac commented 1 month ago

Totally reasonable. I put in the override and it works well. Thx! The mix error message was so weird as it was suggesting it was looking for 1.1 but I checked the source code and I think you guys are right.