search

elixir-error-tracker / error-tracker

🐛 An Elixir-based built-in error reporting and tracking solution
https://hex.pm/packages/error_tracker
Apache License 2.0
418 stars 18 forks source link

Add support for MySQL/MariaDB #89

Closed phihos closed 2 months ago

phihos commented 2 months ago

This PR adds support for the Exto adapter Ecto.Adapters.MyXQL.

Closes #85.

phihos commented 2 months ago

I ran the tests locally and they passed. Someone needs tot trigger the CI so I can fix potential CI issues.

crbelaus commented 2 months ago

Thanks for this PR @phihos! It looks great, I will take a deeper look later this week. Apparently GitHub Actions doesn't like the --connect parameter and the CI is failing.

phihos commented 2 months ago

Hi, thanks for the feedback. I checked the health command and according to an official blogpost the command is correct. I also tried it myself and the script and its argument are accepted. I guess GH actions/docker does not like the single quotes very much. I replaced them with double quotes and added --innodb_initialized which is also recommended.

phihos commented 2 months ago

Fixed the formatting issue. Next run should at least go to the database tests.

phihos commented 2 months ago

I forgot a line in the example test config which I put in my local test config. The tables should exist now. @crbelaus Can you trigger CI again?

phihos commented 2 months ago

Sorry, I accidentally reverted the health-cmd fix. Should work again now.

phihos commented 2 months ago

I also accidentally reverted the formatter fix from yesterday :see_no_evil: Fixed it now.

phihos commented 2 months ago

Finally :partying_face:

phihos commented 2 months ago

Thank you for merging my PR. Now I do not have to maintain a fork for my use-case. Your code was already very well structured and implementation went smoothly. Looking forward to future releases :-)

crbelaus commented 2 months ago

Thank you for merging my PR. Now I do not have to maintain a fork for my use-case. Your code was already very well structured and implementation went smoothly. Looking forward to future releases :-)

Thank you for contributing @phihos! BTW, we have just released v0.3.0 with MySQL/MariaDB support.