search

elixir-europe-training / ELIXIR-Training-SPLASH

https://elixir-europe-training.github.io/ELIXIR-Training-SPLASH/
Other
1 stars 4 forks source link

Remove node indicators from TtT contributors and coordinators #132

Open unode opened 8 months ago

unode commented 8 months ago

Avoids duplicated records in the contributors page and sorts contributors alphabetically for easier maintenance.

unode commented 8 months ago

The CI failure seems unrelated to my changes. Let me know if this isn't the case. I used GitPod to test the changes and the build succeeded there.

mihai-sysbio commented 8 months ago

You're right @unode, that build failure is unrelated. I remember it from the BioHackathon, and where action was re-run and then it would just pass.

unode commented 8 months ago

Hi everyone,

A few additional aspects contributed to the duplicated records so the proposed fix turned out to be a little more complicated than initially expected.

The solution I'm proposing here is to:

  1. Keep affiliation, node information, contact and more in the CONTRIBUTORS.yml file.
  2. Include a node attribute in the CONTRIBUTORS file that contains the node that was originally in parenthesis. This will be added as an extension to the lesson template and will be displayed in the future. The affiliation field also needs to be provided for it to be shown.
  3. All contributors were added as "authors". Let me know if this incorrect and a distinction is intended here.

This PR also includes a fix to the contact information. Previously used a mail attribute that isn't used. The correct attribute should have been email.

Once upstream is merged, node information will be displayed as shown in the screenshot below:

screenshot_2024-03-17_21-36-07_835345180

unode commented 8 months ago

Converting to Draft until https://github.com/ELIXIR-Belgium/elixir-toolkit-theme/pull/230 is merged. Some changes there will likely impact the current PR.