elixir-europe-training / ELIXIR-Training-SPLASH

https://elixir-europe-training.github.io/ELIXIR-Training-SPLASH/
Other
1 stars 4 forks source link

Good sportsmanship regarding ETT usage #138

Open bedroesb opened 6 months ago

bedroesb commented 6 months ago

I think ELIXIR resources should lead the way best practices regarding software attribution, and even more the training platform.

Is there a reason why the ELIXIR Toolkit Theme is taken out of the footer?

I would be very happy to help out with any issues or questions regarding the Theme.

mihai-sysbio commented 5 months ago

Thanks @bedroesb for bringing this up.

The SPLASH website will have been built with input from many sources, and using many open-source source solutions such as the ETT. Instead choosing to favor some over others in a narrow footer, the plan is to provide in-depth acknowledgements on a dedicated page, as already reported in this issue.

For now, following the ETT Attribution expectations, the ETT is acknowledged in the project's readme.

bedroesb commented 5 months ago

In the linked issue there is no mention about other open source solutions, which one do you mean exactly? Because other deployments of the theme within ELIXIR are also having the same issue regarding attribution of projects/infrastructures/funders: ex. https://rdmkit.elixir-europe.org/support and https://www.infectious-diseases-toolkit.org/about/support.

I can say that the main expectations of the theme attribution are that the footer is not overwritten ;)

mihai-sysbio commented 5 months ago

In the linked issue there is no mention about other open source solutions, which one do you mean exactly?

The issue in question has not been refined, so it is expected for it to not be comprehensive. I'm sure this can't be a hint that the only acknowledgement should be towards the ETT.

Because other deployments of the theme within ELIXIR are also having the same issue regarding attribution of projects/infrastructures/funders: ex. https://rdmkit.elixir-europe.org/support and https://www.infectious-diseases-toolkit.org/about/support.

I could imagine this to be also because the footer is not easy to remove, e.g., through a boolean variable in the config. As a developer, I find it puzzling the theme is so customizable yet the footer is not optional.

I can say that the main expectations of the theme attribution are that the footer is not overwritten ;)

While I do understand the desire for attribution, I don't think it's right to expect this without clearly putting that into writing, nor to expect that all websites stick with that footer as a design choice. Moreover, the ETT license is permissive enough for anyone to fork the repository under their org, and to use that without using the footer. Therefore, my suggestion would be to focus on a more robust attribution mechanism.

bedroesb commented 5 months ago

Indeed we make use of an open License and changes can be made accordingly. If this instance was not deployed under the ELIXIR Europe umbrella I would have never opened this issue and I would not have cared at all. But this is an ELIXIR resource reusing another official ELIXIR resource, and of all 19 deployments the only one deleting the logo of the resource out of the footer? That is just odd and I would expect this to happen with deployments from outside our circle that want a clean slate deployment.