Closed bedroesb closed 7 months ago
@apriltuesday I agree. I think it would make sense that the webapp from @xiaoranzhou would be part of an implementation example of MARS using ARC. We could improve on the implementation in the Data Broker platform section of the README.
Hi, I have just created a pull request to the BioHackathon 27 repo by using the following code. https://github.com/xiaoranzhou/mars/tree/27-web Yesterday DataPLANT had a meeting and we are going to integrate the web app into our PlantDataHub. More developments are needed for a production ready tool.
@xiaoranzhou it is great to hear that PlantDataHub will use the web app. It would be nice if the web app would use the python library we are making for MARS. If you need any help in making use of the MARS python library let us know.
In Belgium, we plan to deploy the MARS-CLI in Galaxy Belgium (as Galaxy tool).
I would suggest to keep the code of each deployment of MARS separated in a different repository.
@xiaoranzhou it is great to hear that PlantDataHub will use the web app. It would be nice if the web app would use the python library we are making for MARS. If you need any help in making use of the MARS python library let us know.
In Belgium, we plan to deploy the MARS-CLI in Galaxy Belgium (as Galaxy tool).
I would suggest to keep the code of each deployment of MARS separated in a different repository.
Yes, we plan to use the CLI for sure. I am also participating the development and testing. So there won't be any problem. Should we use the same MARS-CLI or have some adaptation of each implementation? If DataPLANT is have own implementation, it should be also listed in the MARS project.
hello @xiaoranzhou. I think it would be the most beneficial if it is the same code we are using for the same functions. Otherwise when for example the ISA-JSON improves/changes in shape, we have to update a lot more code. In your implementation it might be nice to have a flask/fastapi instance that makes use of the MARS-CLI as a python library, where you could communicate with.
Sorry if I understand things wrongly!
hello @xiaoranzhou. I think it would be the most beneficial if it is the same code we are using for the same functions. Otherwise when for example the ISA-JSON improves/changes in shape, we have to update a lot more code. In your implementation it might be nice to have a flask/fastapi instance that makes use of the MARS-CLI as a python library, where you could communicate with.
Sorry if I understand things wrongly!
@xiaoranzhou that sounds great! It needs for sure to be clear from this repo which types of implementations and solutions exist.
Main differences are:
repository-services
includingisajson-biosamples
andisajson-ena
. Accompanied with a docker compose and a README to set them uptest-data
folderPREVIEW the repo structure here